Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused includes #5293

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from
Draft

chore: Remove unused includes #5293

wants to merge 25 commits into from

Conversation

bthomee
Copy link
Collaborator

@bthomee bthomee commented Feb 18, 2025

High Level Overview of Change

The codebase is filled with includes that are unused, and which thus can be removed.

Context of Change

A code inspection tool revealed various issues with the codebase, among which unused includes.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

@bthomee bthomee marked this pull request as draft February 18, 2025 18:27
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (844646d) to head (2d8409d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5293     +/-   ##
=========================================
+ Coverage     77.9%   78.1%   +0.2%     
=========================================
  Files          791     790      -1     
  Lines        68006   67683    -323     
  Branches      8346    8189    -157     
=========================================
- Hits         52967   52877     -90     
+ Misses       15039   14806    -233     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 87.2% <ø> (ø)
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/base_uint.h 96.8% <ø> (-<0.1%) ⬇️
include/xrpl/basics/chrono.h 100.0% <ø> (ø)
include/xrpl/basics/contract.h 88.9% <ø> (ø)
include/xrpl/basics/random.h 100.0% <ø> (ø)
include/xrpl/beast/core/List.h 92.5% <ø> (ø)
include/xrpl/beast/net/IPAddressConversion.h 66.7% <ø> (ø)
include/xrpl/beast/utility/PropertyStream.h 11.5% <ø> (ø)
... and 177 more

... and 137 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant