Improve checking of the path lengths during Payments #4519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbougalis
suggested changes
May 10, 2023
nbougalis
approved these changes
May 11, 2023
|
Suggested commit message: @a-noni-mousse - please confirm (1) that this PR is ready to merge, in your opinion, and (2) the above commit message looks good (for the squashed commit when this PR is merged). Alternatively, you can suggest a different commit message. |
|
yes the message is okey and this is ready for the merge |
|
@manojsdoshi to consider for the next beta - please squash and use the commit message above |
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 18, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 19, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 19, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 19, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
Merged
ximinez
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 19, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Aug 21, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
ckeshava
pushed a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
Improve the checking of the path lengths during Payments. Previously, the code that did the check of the payment path lengths was sometimes executed, but without any effect. This changes it to only check when it matters, and to not make unnecessary copies of the path vectors. Signed-off-by: Manoj Doshi <mdoshi@ripple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The code that does the check of the payment path lengths was sometimes executed but without an effect so change it to only work when it matters and to not make not necessary copies of the path vectors.
Context of Change
The code checks size of payment path lengths but it is only pertinente when executing again open view and doing the work when not open.
This is only start I think there are also other issue with the paths codes that need to be fixed.
Type of Change
Test Plan
Do the unit tests.