Allow NFT to be burned when number of offers is greater than 500 (part of NonFungibleTokensV1_2 amendment)

src/ripple/app/tx/impl/NFTokenBurn.cpp

@@ -115,12 +115,12 @@ NFTokenBurn::doApply()
         // Because the number of sell offers is likely to be less than
         // the number of buy offers, we prioritize the deletion of sell
         // offers in order to clean up sell offer directory
-        int const deletedSellOffers = nft::removeTokenOffersWithLimit(
+        std::size_t const deletedSellOffers = nft::removeTokenOffersWithLimit(
             view(),
             keylet::nft_sells(ctx_.tx[sfNFTokenID]),
             maxDeletableTokenOfferEntries);
 
-        if (maxDeletableTokenOfferEntries - deletedSellOffers > 0)
+        if (maxDeletableTokenOfferEntries > deletedSellOffers)
         {
             nft::removeTokenOffersWithLimit(
                 view(),

src/ripple/app/tx/impl/details/NFTokenUtils.cpp

@@ -521,17 +521,17 @@ findTokenAndPage(
     return std::nullopt;
 }
 
-int
+std::size_t
 removeTokenOffersWithLimit(
     ApplyView& view,
     Keylet const& directory,
-    int maxDeletableOffers)
+    std::size_t maxDeletableOffers)
 {
     if (maxDeletableOffers == 0)
         return 0;
 
     std::optional<std::uint64_t> pageIndex{0};
-    int deletedOffersCount = 0;
+    std::size_t deletedOffersCount = 0;
 
     do
     {

src/ripple/app/tx/impl/details/NFTokenUtils.h

@@ -55,11 +55,11 @@ constexpr std::uint16_t const flagTransferable = 0x0008;
 
 /** Delete up to a specified number of offers from the specified token offer
  * directory. */
-int
+std::size_t
 removeTokenOffersWithLimit(
     ApplyView& view,
     Keylet const& directory,
-    int maxDeletableOffers);
+    std::size_t maxDeletableOffers);
 
 /** Returns tesSUCCESS if NFToken has few enough offers that it can be burned */
 TER

src/ripple/protocol/Protocol.h

@@ -67,7 +67,7 @@ std::size_t constexpr maxDeletableDirEntries = 1000;
 std::size_t constexpr maxTokenOfferCancelCount = 500;
 
 /** The maximum number of offers in an offer directory for NFT to be burnable */
-int constexpr maxDeletableTokenOfferEntries = 500;
+std::size_t constexpr maxDeletableTokenOfferEntries = 500;
 
 /** The maximum token transfer fee allowed.