Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Array parsing in new config #1896

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

kuznetsss
Copy link
Collaborator

Improving array parsing in config:

  • Allow null values in arrays for optional fields
  • Allow empty array even for required field
  • Allow to not put an empty array in config even if array contains required fields

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.95%. Comparing base (427ba47) to head (e62a02c).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1896      +/-   ##
===========================================
+ Coverage    72.71%   72.95%   +0.23%     
===========================================
  Files          333      335       +2     
  Lines        13525    13676     +151     
  Branches      6881     6944      +63     
===========================================
+ Hits          9835     9977     +142     
- Misses        1785     1787       +2     
- Partials      1905     1912       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a few nits 👍 🚀

PeterChen13579
PeterChen13579 previously approved these changes Feb 17, 2025
Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@kuznetsss kuznetsss merged commit 4b17880 into XRPLF:develop Feb 18, 2025
21 checks passed
@kuznetsss kuznetsss deleted the Fix_array_in_config branch February 18, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants