Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CacheLoader causes crash when no cache is used #1853

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kuznetsss
Copy link
Collaborator

If cache is disabled or Clio starts with and empty DB, loader_ inside cache is not created. So calling CacheLoader::stop() or CacheLoader::wait() was causing crash.

@kuznetsss kuznetsss requested a review from godexsoft January 28, 2025 16:44
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this 👍

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (540e938) to head (ed81529).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1853      +/-   ##
===========================================
+ Coverage    71.61%   71.63%   +0.02%     
===========================================
  Files          330      330              
  Lines        13411    13413       +2     
  Branches      6824     6826       +2     
===========================================
+ Hits          9604     9609       +5     
+ Misses        1923     1920       -3     
  Partials      1884     1884              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuznetsss kuznetsss merged commit 75354fb into XRPLF:develop Jan 28, 2025
17 checks passed
@kuznetsss kuznetsss deleted the Fix_cache_loader_crash branch January 28, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants