Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use mutex from utils #1851

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

kuznetsss
Copy link
Collaborator

Fixes #1359.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (6ef6ca9) to head (9d3484e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/prometheus/impl/HistogramImpl.hpp 75.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1851      +/-   ##
===========================================
+ Coverage    71.61%   71.62%   +0.01%     
===========================================
  Files          330      330              
  Lines        13413    13411       -2     
  Branches      6826     6824       -2     
===========================================
  Hits          9606     9606              
  Misses        1922     1922              
+ Partials      1885     1883       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of how more places need to write template now and even less of a fan of operator[](m) but it works. You can avoid the extra template via a helper function but that makes the API less discoverable so that's a trade off I suppose.

@kuznetsss kuznetsss merged commit 540e938 into XRPLF:develop Jan 27, 2025
17 checks passed
@kuznetsss kuznetsss deleted the 1359_Use_util_mutex branch January 27, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mutex from utils
3 participants