-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support clang 16 in docker CI #1348
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1348 +/- ##
===========================================
+ Coverage 64.38% 64.44% +0.05%
===========================================
Files 248 248
Lines 10544 10544
Branches 5839 5839
===========================================
+ Hits 6789 6795 +6
+ Misses 1920 1914 -6
Partials 1835 1835 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good improvements 👍 Just a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Fixes #1175
Currently clang-tidy is producing a lot of interesting output. But i think this can be handled outside of this PR now.