Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clang 16 in docker CI #1348

Merged
merged 21 commits into from
Apr 15, 2024
Merged

Conversation

godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Apr 11, 2024

Fixes #1175

  • Adds clang-16 as a secondary compiler to the docker CI image
  • Slightly improves how gcc-12 is integrated
  • Sets up the CI to make use of clang and run tests compiled by it alongside gcc's build
  • These are not the robots you are looking for

Currently clang-tidy is producing a lot of interesting output. But i think this can be handled outside of this PR now.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 64.44%. Comparing base (1fe42c8) to head (1fd2018).

❗ Current head 1fd2018 differs from pull request most recent head d6ce1f9. Consider uploading reports for the commit d6ce1f9 to get more accurate results

Files Patch % Lines
src/etl/impl/LedgerLoader.hpp 0.00% 2 Missing ⚠️
src/etl/impl/SubscriptionSource.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1348      +/-   ##
===========================================
+ Coverage    64.38%   64.44%   +0.05%     
===========================================
  Files          248      248              
  Lines        10544    10544              
  Branches      5839     5839              
===========================================
+ Hits          6789     6795       +6     
+ Misses        1920     1914       -6     
  Partials      1835     1835              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvements 👍 Just a few comments.

@godexsoft godexsoft requested a review from kuznetsss April 12, 2024 01:26
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@godexsoft godexsoft merged commit e931f27 into XRPLF:develop Apr 15, 2024
16 checks passed
kuznetsss pushed a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build clio with clang
2 participants