Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement amm_info handler #1060

Merged
merged 20 commits into from
Jan 11, 2024
Merged

Conversation

godexsoft
Copy link
Collaborator

As @arihantkothari could not continue working on this I'm taking it over to finish the missing/failing unit tests and finalize the handler.

Note: Previous work on this code was here.

@godexsoft godexsoft mentioned this pull request Dec 22, 2023
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (d30e63d) 54.08% compared to head (8af86a5) 54.72%.
Report is 2 commits behind head on develop.

❗ Current head 8af86a5 differs from pull request most recent head 3714b38. Consider uploading reports for the commit 3714b38 to get more accurate results

Files Patch % Lines
src/rpc/handlers/AMMInfo.cpp 81.92% 17 Missing and 13 partials ⚠️
src/rpc/common/Validators.cpp 78.57% 1 Missing and 2 partials ⚠️
src/rpc/RPCHelpers.cpp 84.61% 1 Missing and 1 partial ⚠️
src/rpc/common/impl/HandlerProvider.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    54.08%   54.72%   +0.63%     
===========================================
  Files          203      206       +3     
  Lines        10288    10475     +187     
  Branches      5454     5582     +128     
===========================================
+ Hits          5564     5732     +168     
- Misses        3399     3416      +17     
- Partials      1325     1327       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godexsoft godexsoft marked this pull request as ready for review January 11, 2024 12:59
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a few comments.

@godexsoft godexsoft requested a review from kuznetsss January 11, 2024 15:50
@godexsoft godexsoft merged commit f4df5c2 into XRPLF:develop Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants