-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement amm_info handler #1060
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1060 +/- ##
===========================================
+ Coverage 54.08% 54.72% +0.63%
===========================================
Files 203 206 +3
Lines 10288 10475 +187
Branches 5454 5582 +128
===========================================
+ Hits 5564 5732 +168
- Misses 3399 3416 +17
- Partials 1325 1327 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just a few comments.
As @arihantkothari could not continue working on this I'm taking it over to finish the missing/failing unit tests and finalize the handler.
Note: Previous work on this code was here.