Skip to content

Commit

Permalink
style: clang-tidy auto fixes (#1663)
Browse files Browse the repository at this point in the history
Fixes #1662.

---------

Co-authored-by: kuznetsss <15742918+kuznetsss@users.noreply.github.com>
Co-authored-by: Peter Chen <ychen@ripple.com>
  • Loading branch information
3 people authored Sep 23, 2024
1 parent c8e3da6 commit 3343c1f
Showing 1 changed file with 6 additions and 16 deletions.
22 changes: 6 additions & 16 deletions src/util/newconfig/ConfigConstraints.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class Constraint {
// see here for more info:
// https://stackoverflow.com/questions/72835571/constexpr-c-error-destructor-used-before-its-definition
// https://godbolt.org/z/eMdWThaMY
constexpr virtual ~Constraint() noexcept {}; // NOLINT(google-default-destructor)
constexpr virtual ~Constraint() noexcept {}; // NOLINT(modernize-use-equals-default)

/**
* @brief Check if the value meets the specific constraint.
Expand Down Expand Up @@ -155,9 +155,7 @@ class Constraint {
*/
class PortConstraint final : public Constraint {
public:
constexpr ~PortConstraint() override
{
} // NOLINT(google-default-destructor)
constexpr ~PortConstraint() override {}; // NOLINT(modernize-use-equals-default)

private:
/**
Expand Down Expand Up @@ -187,9 +185,7 @@ class PortConstraint final : public Constraint {
*/
class ValidIPConstraint final : public Constraint {
public:
constexpr ~ValidIPConstraint() override
{
} // NOLINT(google-default-destructor)
constexpr ~ValidIPConstraint() override {}; // NOLINT(modernize-use-equals-default)

private:
/**
Expand Down Expand Up @@ -229,9 +225,7 @@ class OneOf final : public Constraint {
{
}

constexpr ~OneOf() override
{
} // NOLINT(google-default-destructor)
constexpr ~OneOf() override {}; // NOLINT(modernize-use-equals-default)

private:
/**
Expand Down Expand Up @@ -285,9 +279,7 @@ class NumberValueConstraint final : public Constraint {
{
}

constexpr ~NumberValueConstraint() override
{
} // NOLINT(google-default-destructor)
constexpr ~NumberValueConstraint() override {}; // NOLINT(modernize-use-equals-default)

private:
/**
Expand Down Expand Up @@ -328,9 +320,7 @@ class NumberValueConstraint final : public Constraint {
*/
class PositiveDouble final : public Constraint {
public:
constexpr ~PositiveDouble() override
{
} // NOLINT(google-default-destructor)
constexpr ~PositiveDouble() override {}; // NOLINT(modernize-use-equals-default)

private:
/**
Expand Down

0 comments on commit 3343c1f

Please sign in to comment.