Smart quotes shouldn't break the pyxform

[yanokwa]

Works: selected(${branch}, 'o')

Doesn't work: selected(${branch}, ‘o’)

test.xlsx

It'd be good if smart quotes were allowed in labels, but I don't know how this plays with UTF-8 and the XML spec and JavaRosa.

[dorey]

Any objections to replacing all of these smart characters with their simpler equivalents?

[yanokwa]

I personally don't mind, but a lot of design people really like smart quotes.

[MartijnR]

Smart quotes are not supported in XPath 1.0 as far as I know, so replacing might be the only way.

See in browser javascript console:

document.evaluate('string("o")', document.documentElement, document.createNSResolver(document.documentElement), XPathResult.STRING_TYPE, null).stringValue

versus:

document.evaluate('string(‘o’)', document.documentElement, document.createNSResolver(document.documentElement), XPathResult.STRING_TYPE, null).stringValue

[yanokwa]

Pretty compelling evidence :)

Sounds like replacing is the right way to go.

[dorey]

I'll write a test of this change.
Then fixing it shouldn't be hard, just a matter of finding the best place to do it

[dorey]

Should smart quotes in labels be simplified as well? Or just constraints and relevants?

I'll aim to replace all “smart” quotes throughout the document.

[dorey]

All fancy quote characters in any field in the survey sheet will be replaced.

This change does not touch the settings or choices sheets. (Should it?)

[yanokwa]

I think you should replace smart quotes everywhere.

Settings has form_title and version and what you enter there will show up in the XML. Ditto with the names and labels in the choices.

[yixi8524]

@yanokwa Why do we need to replace all the smart quotes everywhere? Should we consider about this replace function will change the user's real content in the Form? Like label and hint?

[fendiaoxiaoshuazi]

The smart quotes are used in Chinese, I guess other languages also use smart quotes often. Therefore, this conversion may affect the survey content of some multiple-language surveys.

[lognaturel]

@yixi8524 @fendiaoxiaoshuazi if you are interested in exploring a way to maintain smart quotes within strings and hints, please consider opening a PR! Please verify output with the latest releases of both ODK Collect and Enketo Express.