Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Following the breaking change of https://github.com/AxFoundation/strax/pull/910 #1452

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Following the breaking change of https://github.com/AxFoundation/strax/pull/910 #1452

merged 1 commit into from
Oct 16, 2024

Conversation

dachengx
Copy link
Collaborator

Following the breaking change of AxFoundation/strax#910

Because we changed digitize_top to store_data_top.

Why? Because

  1. Better to use the same variable name with exactly the same meaning everywhere.
  2. Anyway we are making a lot of breaking changes.

@dachengx dachengx marked this pull request as ready for review October 16, 2024 15:07
@coveralls
Copy link

Coverage Status

coverage: 90.273% (+0.02%) from 90.253%
when pulling 0660022 on store_data_top
into df0d488 on master.

@dachengx dachengx merged commit a759148 into master Oct 16, 2024
7 of 8 checks passed
@dachengx dachengx deleted the store_data_top branch October 16, 2024 15:47
This was referenced Oct 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @coveralls