Fix mac compilation #497
Merged
Fix mac compilation #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xrdavies
commented
Dec 25, 2018
- Fix mac compilation
sgaragagghu
reviewed
Dec 27, 2018
| @@ -66,7 +66,12 @@ extern int g_disable_mining; | |||
| //Test network and main network have different types of the block headers, so blocks from different networks are incompatible | |||
| extern enum xdag_field_type g_block_header_type; | |||
|
|
|||
| #if defined (__MACOS__) || defined (__APPLE__) | |||
| extern int is_pool(void); | |||
| extern int is_wallet(void); | |||
There was a problem hiding this comment.
What's the compilation error? it is strange to me,
inline int is_pool(void) { return g_xdag_type == XDAG_POOL; }
it is C standard... anything strange.
extern int is_pool(void); <-- it is not inlined anyway, it is only inlined in global.c file but not in other files
There was a problem hiding this comment.
I tried it on my mac and i have no errors about it... :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.