Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactoring and renamings #485

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Some refactoring and renamings #485

merged 3 commits into from
Dec 17, 2018

Conversation

jonano614
Copy link
Contributor

@jonano614 jonano614 commented Dec 15, 2018 •
edited
Loading

  • path /dus/programs/dfstools/source/dfslib simplified to /dfslib
  • path /ldus/source/include/ldus simplified to /ldus
  • dfsrsa.h and dfsrsa.c files moved to folder /dfslib
  • files sha256.h and sha256.c moved to subfolder /client/algorithms, assembler files moved to that folder too
  • crc library moved from /dus/programs/dar/source/include to /client/algorithms
  • file /dnet/system.h renamed to /dnet/dnet_system.h to avoid confusion with /client/system.h
  • #if defined(_WIN32) || defined(_WIN64) simplified to #ifdef _WIN32. _WIN32 is always defined in Windows. The difference between x64 and x86 is in _WIN64 directive.
  • new files string_utils.h and string_utils.c in the /client/utils folder

@ghost ghost assigned jonano614 Dec 15, 2018
@ghost ghost added the in progress label Dec 15, 2018
@jonano614
Merge remote-tracking branch 'upstream/develop' into project_refactoring
95b3abf 
# Conflicts:
#	client/init.c
#	client/xdag_config.c
#	client/xdag_config.h
@sgaragagghu
Copy link
Contributor

ps: who will merge it, you can use squash to collapse it into one commit

xrdavies
xrdavies approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@xrdavies xrdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great efforts!!

@xrdavies xrdavies merged commit bf6b3bb into XDagger:develop Dec 17, 2018
@ghost ghost removed the in progress label Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrdavies xrdavies xrdavies approved these changes

@sgaragagghu sgaragagghu sgaragagghu approved these changes

Assignees

@jonano614 jonano614

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonano614 @sgaragagghu @xrdavies