Config file for pools #461
Conversation
# Conflicts: # client/Makefile # client/xdag_config.c # client/xdag_config.h
| char *line = NULL; | ||
| int line_len = 0, buf_len = 0; | ||
|
|
||
| while(!feof(fp)) |
There was a problem hiding this comment.
You read line from file. Do the lines really can be so long, so you need to read them in several iterations?
There was a problem hiding this comment.
Because I am worried that there may be an expansion later.
Delete 4 empty lines combine variable declaration and usage len-2+1 Maybe just len-1
|
All strdup is free when xdag_config_close closed |
saw now, great |
|
your parser seems good! |
Thank you for your suggestion, ok, I will modify it. |
| { | ||
| return TYPE_KEY; | ||
| } | ||
| return TYPE_UNKNOW; |
There was a problem hiding this comment.
can you print the line in xdag_err TYPE_UNKNOW case?
There was a problem hiding this comment.
can you print the line in xdag_err TYPE_UNKNOW case?
ok
client/xdag_config.c
Outdated
|
|
||
|
|
||
| char * get_pool_config(const char *path){ | ||
| static char result[80]; |
|
|
||
| char * get_pool_config(const char *path){ | ||
| static char result[80]; | ||
| if(path) { |
There was a problem hiding this comment.
why don't use strcat? strncat(result, str,strlen(str)) makes no sense
and i see that you doesn't check the buffer overflow!
|
Just two questions:
|
1.No default path for config file，but there is a sample file in "/xdag/client/example.ini". The xdag startup command is as follows： |
|
Ok, thank you for you great efforts. |
#329 Config file for pools