Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with storage path is fixed #29

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Bug with storage path is fixed #29

merged 1 commit into from
Mar 20, 2018

Conversation

jonano614
Copy link
Contributor

@jonano614 jonano614 commented Mar 19, 2018 •
edited
Loading

Address of account could be different if wallet is started from another directory for the first time.
Declarations for some varialbles are combined with usages.

@jonano614 jonano614 requested a review from xrdavies March 19, 2018 22:48
xrdavies
xrdavies approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@xrdavies xrdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mainly about add new function to check if file existed and re-style the code. It's great. Thank you for your great effort.

@xrdavies xrdavies merged commit 0ae6338 into XDagger:develop Mar 20, 2018
@jonano614 jonano614 deleted the storage_path_bugfix branch March 25, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrdavies xrdavies xrdavies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonano614 @xrdavies