Fix alternative output formats #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new value parser introduced in [1] did not parse the option into a `Format`, but rather into a string, thus breaking alternative output formats, as a different type was expected. Fixes: XAMPPRocky#1170 [1]: 9627a24 (Fix cargo audit issues (XAMPPRocky#1137))
|
Thank you for your PR! Feel free to report it to clap's repo, I agree that it shouldn't happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new value parser introduced in [1] did not parse the option into a
Format, but rather into a string, thus breaking alternative output formats, as a different type was expected.Fixes: #1170
[1]: 9627a24 (Fix cargo audit issues (#1137))
N.b: Should this be reported as a bug somewhere? Type errors being propagated to runtime sounds like something
clapshould not do.