Add conclusion, completed_at and output fields to create check api #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
reviewed
Oct 9, 2023
ikkerens
commented
Oct 11, 2023
XAMPPRocky
reviewed
Oct 11, 2023
|
I've ran the formatter to fix some of the issues, though my clippy locally still fails due to code that is not mine. |
maflcko
approved these changes
Nov 29, 2023
|
lgtm |
|
Friendly ping @XAMPPRocky :) |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The create checks api also allows for immediate reporting of its completion status for quick status reports (for example, verifying that a PR name matches a regex).
This PR adds those fields to the create check api and builder, skipping the need for another request to update the check immediately after creating it.