-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change coco utils to use high-level interface #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 51 51
Lines 2144 2063 -81
==========================================
- Hits 2143 2062 -81
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 697157b into bc1a71d - view on LGTM.com new alerts:
|
697157b
to
b9544c8
Compare
This pull request introduces 1 alert when merging b9544c8 into bc1a71d - view on LGTM.com new alerts:
|
b9544c8
to
2cd2609
Compare
Using a fill with the CLI tool is now done by specifying it in the configuration for the |
I believe the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably rename the gen_coco_sal
module to something simpler now, like maybe just coco
.
c73e3fc
to
b6f858c
Compare
@schencej With the function name change to |
a3f2ed7
to
9e79338
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just needs an autosquash and I think we're good to go. @brianhhu any last comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I made a few very minor comments, none of them are really blocking this PR though.
"\n", | ||
"The number of masks for our image perturber is set to `20`.\n", | ||
"The number of perturbation masks image is set to `20`.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The number of perturbation masks image is set to `20`.\n", | |
"The number of perturbation masks is set to `20`.\n", |
9e79338
to
d7088ba
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Addressed the last round of comments from @brianhhu and rebased. Should be good to go. |
LGTM, thanks- feel free to merge! |
Highlights:
gen_coco_sal()
is gone and in its place isparse_coco_dset()
which takes akwcoco.CocoDataset
object and creates matrices for use with the new high-level detector interfacesal-on-coco-dets
was updated to use this new utility function and high-level interface combination