Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add ignoreContexts option #32

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fcurella
Copy link

This adds the ignoreContexts option, so external checks can be excluded as well.

I've pretty much copied the code for Checks, and replaced ->name() with ->context() and ->status() with ->state().

PS: I haven't written PHP in a decade, so I don't what current idiomatic code looks like nowadays. Feel free to nitpick :)

@fcurella fcurella force-pushed the ignore-contexts branch 4 times, most recently from da87815 to 2ea6a14 Compare September 18, 2020 17:17
@fcurella fcurella changed the title Add ignoreContexts option [WIP] Add ignoreContexts option Sep 18, 2020
@fcurella
Copy link
Author

Marking as WIP until I update all the tests

@fcurella fcurella marked this pull request as draft September 18, 2020 17:19
@fcurella fcurella force-pushed the ignore-contexts branch 2 times, most recently from 8aaef14 to 3aa2fb2 Compare September 18, 2020 17:45
@WyriHaximus WyriHaximus added this to the v1.3.0 milestone Sep 18, 2020
@WyriHaximus
Copy link
Owner

Awesome, looking forward to review this when it is ready 👍 !

@boring-cyborg boring-cyborg bot added Dependencies 📦 Pull requests that update a dependency file Docker 🐳 Pull requests that relate to Docker labels Sep 18, 2020
@WyriHaximus WyriHaximus removed this from the v1.3.0 milestone Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies 📦 Pull requests that update a dependency file Docker 🐳 Pull requests that relate to Docker MarkDown 📝 PHP 🐘 Hypertext Pre Processor Source 🔮 Tests 🧪 YAML 🍄
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants