-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved creation and configuration #47
Conversation
fyi @cwfitzgerald: this changes the entry point for the tracy integration you added a lil bit |
@Imberflur: disabling the profiler is back, handled way better than before I think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the interface to enabled/disable scopes at runtime ❤️
The overall approach looks pretty good to me. I left a few notes/questions.
GpuProfiler
is createdThe later made it clear to me that there's a bit of love needed to make
GpuProfiler
useful when using it with multiple command encoder, see #46After that one is out of the way it's time to get ready for the next wgpu version which allows getting timers directly on compute/render pass boundaries (which can make quite the difference under the hood especially on Metal). This will affect the
Scope
structs but will otherwise fit in neatly I believe as it's mostly an expansion of what's there, not a replacement :)