Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved creation and configuration #47

Merged
merged 8 commits into from
Oct 8, 2023
Merged

Conversation

Wumpf
Copy link
Owner

@Wumpf Wumpf commented Sep 24, 2023

  • settings struct that can be changed after the fact
  • Overhauled how GpuProfiler is created
    • creation with tracy context is now a separate method which is optional even if tracy feature is active
  • test for nesting of profiling scopes with and without support for encoder/pass timer queries
  • various docs improvements on the way

The later made it clear to me that there's a bit of love needed to make GpuProfiler useful when using it with multiple command encoder, see #46
After that one is out of the way it's time to get ready for the next wgpu version which allows getting timers directly on compute/render pass boundaries (which can make quite the difference under the hood especially on Metal). This will affect the Scope structs but will otherwise fit in neatly I believe as it's mostly an expansion of what's there, not a replacement :)

@Wumpf Wumpf changed the title Improved creation and settings Improved creation and configuration Sep 24, 2023
@Wumpf
Copy link
Owner Author

Wumpf commented Sep 24, 2023

fyi @cwfitzgerald: this changes the entry point for the tracy integration you added a lil bit

@Wumpf
Copy link
Owner Author

Wumpf commented Sep 24, 2023

@Imberflur: disabling the profiler is back, handled way better than before I think :)

@Wumpf Wumpf requested a review from Imberflur September 29, 2023 09:11
Copy link
Collaborator

@Imberflur Imberflur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the interface to enabled/disable scopes at runtime ❤️

The overall approach looks pretty good to me. I left a few notes/questions.

@Wumpf Wumpf merged commit 8824a2b into main Oct 8, 2023
@Wumpf Wumpf deleted the improved-creation-and-settings branch October 8, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants