Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realm creation using CLI #77 #82

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

fyrbach
Copy link
Member

@fyrbach fyrbach commented Feb 20, 2023

Adds missing binding of @LocalOnly NullNotificationBroker that was causing com.google.inject.ConfigurationException while realm creation using ssoadm create-realm command.

The change in CTSNotificationBroker is about fixing a forgotten modification in cab13b6.

Fixes #77.

Verified

This commit was signed with the committer’s verified signature.
fyrbach Jan Fyrbach
Adds missing binding of `@LocalOnly` `NullNotificationBroker` that was
causing `com.google.inject.ConfigurationException` while realm creation
using `ssoadm create-realm` command.
@fyrbach fyrbach requested a review from pavelhoral February 20, 2023 12:37
Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelhoral pavelhoral merged commit 1d86256 into WrenSecurity:main Feb 20, 2023
@fyrbach fyrbach deleted the fix/ssoadm-create-realm branch February 20, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating realm via ssoadm ends with ConfigurationException
2 participants