Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2021-37154] Escape SAML request inResponseTo attribute. #130

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

karelmaxa
Copy link
Member

This PR introduces XML escaping of the SAML response attribute inResponseTo to resolve the security vulnerability published as a CVE-2021-37154.

I was able to reproduce the exploit using the current version built with JDK 17.

@karelmaxa karelmaxa requested a review from pavelhoral June 30, 2023 11:08
@karelmaxa karelmaxa changed the title Escape SAML request inResponseTo attribute. [CVE-2021-37154] Escape SAML request inResponseTo attribute. Jun 30, 2023
Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelhoral pavelhoral merged commit d5c02f4 into WrenSecurity:main Jun 30, 2023
@karelmaxa karelmaxa deleted the cve-2021-37154 branch July 10, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants