Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Added straightforward task description #8

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Added straightforward task description #8

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46791e8
Added straightforward tasks description
jskrzynski-wr Oct 16, 2020
f28c99c
Straightforward task description - typo fix
jskrzynski-wr Oct 16, 2020
9c0cde8
Straightforward task description - capital plus bold
jskrzynski-wr Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# recruitment-tl-task-public

## Description
Your task is NOT to write code, but to perform a code review.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kuba I would write it bold with capital letters. It should make that more prominent. bold

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** bold ** (without spaces makes the text bold)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, done.


Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Point out all the issues with the code quality and how it conforms to clean code (and any other you can think of) principles. Make sure that you look at the code from all possible angles and describe all the possible improvements. Detail all the changes that would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc.

### Task to be reviewed
Expand Down