Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should TAKE the icon files, and PUSH THEM SOMEWHERE ELSE! - tg rebase edition #883

Open
wants to merge 1 commit into
base: modern-tg
Choose a base branch
from

Conversation

hex37
Copy link
Contributor

@hex37 hex37 commented Feb 22, 2025

About The Pull Request

x

Moves all of the .dmi files in the modules/wod13 directory to /icons/wod13

Why It's Good For The Game

It makes the wod13 module much more nicely organized. A well maintained code base shouldn't mix their peas and carrots in the same folder.

Testing Photographs and Procedure

Screenshots&Videos
2025-02-22.15-31-38.mp4

Changelog

🆑
refactor: moves the icons files from modules/wod13 to icons/wod13
/:cl:

@hex37 hex37 changed the title We should TAKE THE ICONS, and PUSH THEM SOMEWHERE ELSE! - tg rebase edition We should TAKE the icon files, and PUSH THEM SOMEWHERE ELSE! - tg rebase edition Feb 22, 2025
@XanderDox XanderDox added Code Improvement Code is now easier to copy paste. Refactor Makes the code harder to read Sprites A bikeshed full of soulless bikes. labels Feb 22, 2025
@XeonMations
Copy link
Contributor

What's the difference between #879, #881 and this PR? Do they not all do the same thing?

@hex37
Copy link
Contributor Author

hex37 commented Feb 23, 2025

@XeonMations they are all identical but merge to different repos, so they won't cause issues down the line despite making some structural changes to file organization

@hex37
Copy link
Contributor Author

hex37 commented Feb 23, 2025

metek said they would review it if I mirrored the pr to their repo so I did both theirs and yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Code is now easier to copy paste. Refactor Makes the code harder to read Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants