Bouncer bug fixes, improvements and refinements #796
+163
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we seem to have this runtime happening as well about 8 times at every roundstart please check all the bouncer subtypes |
|
@Miraviel ty for the heads up, I'll dig into it |
|
@Miraviel Pushed a fix: |
Miraviel
requested changes
Feb 19, 2025
There was a problem hiding this comment.
I walked up to the bouncers as a Nosferatu. They asked me to show my face. I took off my mask. They started to shoot at me. This is something that'd happen to players often if they were prompted an NPC to take off their mask
Went to another bouncer, shift-clicked them, clicked the mask icon. They let me thru with this extra runtime in tow:
verb name: Examine (/mob/verb/examinate)
usr: Miraviel/(Kane Nosferatu)
usr.loc: (Millennium Tower F1 (122,120,3))
src: Unknown (/mob/living/carbon/human)
src.loc: the shuttle floor (122,120,3) (/turf/open/floor/mineral/plastitanium)
call stack:
Unknown (/mob/living/carbon/human): Examine(Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium))
Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium): ShiftClick(Unknown (/mob/living/carbon/human))
Unknown (/mob/living/carbon/human): ShiftClickOn(Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium))
Unknown (/mob/living/carbon/human): ClickOn(Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium), "icon-x=18;icon-y=13;left=1;shi...")
Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium): Click(the plating (123,121,3) (/turf/open/floor/plating/vampplating), "mapwindow.map", "icon-x=18;icon-y=13;left=1;shi...")
Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium): Click(the plating (123,121,3) (/turf/open/floor/plating/vampplating), "mapwindow.map", "icon-x=18;icon-y=13;left=1;shi...")
Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium): Click(the plating (123,121,3) (/turf/open/floor/plating/vampplating), "mapwindow.map", "icon-x=18;icon-y=13;left=1;shi...")
Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium): Click(the plating (123,121,3) (/turf/open/floor/plating/vampplating), "mapwindow.map", "icon-x=18;icon-y=13;left=1;shi...")
Marla Jowers (/mob/living/carbon/human/npc/bouncer/elysium): Click(the plating (123,121,3) (/turf/open/floor/plating/vampplating), "mapwindow.map", "icon-x=18;icon-y=13;left=1;shi...")
I can look into the runtime, though I might run into trouble if I can't replicate. Do you have any idea about a more clear way for the Bouncer to tell the player to shift click them? |
|
changed code so bouncers, guards and strippers no longer panic over ugly people |
|
removed the mapping components of the PR |
|
update: Blocks players from bypassing the barrier by climbing down a hole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes some bugs for bouncers:
Why It's Good For The Game
Allows masked people to enter, if they show their face first, and allows masked people to persuade for access.
Also- makes the map more conducive to interacting with vip barriers.
Testing Photographs and Procedure
2025-02-19.13-40-00.mp4
Changelog
🆑
add: Blocks entry for masked people until they show their face or talk their way through
refactor: Allows masked people to persuade their way inside
fix: ghosts cannot rizz bouncers
balance: Bouncers and security guards no longer aggro onto people violating masquerade with their ugly.
balance: Strippers no longer panic & trigger masquerade violations on people violating masquerade with their ugly
refactor: Checkeyewitness now checks for the type of infraction caused before triggering aggro, also more early returns
add: player hints on how to interact with bouncers
add: bouncers have more natural standing directions instead of always facing south.
refactor: when a bouncer's direction resets, they adopt the direction set within the map file.
fix: runtime when interacting with bouncers
fix: Blocks players from bypassing the barrier by climbing down through open space
/:cl: