194-align-training-window-with-user-defined-temporal-extent #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvantricht
requested changes
Oct 16, 2024
src/worldcereal/utils/refdata.py
Outdated
|
|
||
| def get_best_valid_date(row): | ||
| """ | ||
| Determine the best valid date for a given row based on forward and backward shifts. |
There was a problem hiding this comment.
is this a standard Numpy docstring? Hard to see from github changes, just checking with you.
src/worldcereal/utils/refdata.py
Outdated
|
|
||
| # get the middle of the user-defined temporal extent | ||
| start_date, end_date = processing_period.to_datetime() | ||
| processing_period_middle_ts = start_date + pd.DateOffset(months=5) |
There was a problem hiding this comment.
the middle is hard to define with an even number of timesteps. Should we be aligned with e.g. this? And therefore rather add 6 months? I may be wrong here, was just wondering.
src/worldcereal/utils/refdata.py
Outdated
| # save the true valid_date for later | ||
| true_valid_date_map = sample_dates.set_index("sample_id")["valid_date"] | ||
|
|
||
| # calculate the shifts and assignt new valid date |
added 9 commits
October 16, 2024 09:21
kvantricht
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.