Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tile size #106

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Custom tile size #106

merged 2 commits into from
Jul 8, 2024

Conversation

VincentVerelst
Copy link
Contributor

@kvantricht , there was already an option in GFMap to set a custom tile_size when loading in collections, so I've just added an optional argument in worldcereal_preprocessed_inputs_gfmap to set a tilesize

@VincentVerelst VincentVerelst requested a review from kvantricht July 8, 2024 12:40
Copy link
Contributor

@kvantricht kvantricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it safer to explicitly state if tile_size is not None instead of doing a boolean evaluation?

@VincentVerelst
Copy link
Contributor Author

Isn't it safer to explicitly state if tile_size is not None instead of doing a boolean evaluation?

aha yes, thanks for the suggestion! changes have been made

Copy link
Contributor

@kvantricht kvantricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@kvantricht kvantricht merged commit 1e74a22 into main Jul 8, 2024
1 check passed
@kvantricht kvantricht deleted the custom_tile_size branch July 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants