-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accessing private members of child modules #229
Conversation
In dart 2.19 mocks can no longer handle calls into these private members. Perform the call carefully.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
lib/src/lifecycle_module.dart
Outdated
) { | ||
try { | ||
childModule?._parentContext = context; | ||
} catch (e) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to add a comment inside the {}
saying that swallowing the exception and not logging or acting on it is intentional so someone doesn't come along later and remove this try catch thinking that it doesn't do anything.
+10 @Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
In dart 2.19 mocks can no longer handle calls into these private members.
Changes
Wrap calls into _parentContext in a try...catch to handle this gracefully.
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: