Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-3349 Relax Action handler return type #80

Merged
merged 1 commit into from
Jan 26, 2017
Merged

CP-3349 Relax Action handler return type #80

merged 1 commit into from
Jan 26, 2017

Conversation

maxwellpeterson-wf
Copy link
Member

Issue

If strong mode is enabled on one of your Action handlers is marked as an async function, the following analysis error is shown:

error-screenshot

async functions can be very useful for Action handlers, because you may want to leverage await.

Changes

Source:

  • Relax return type of Action handler from void to dynamic.

Testing

  • CI Passes

Code Review

@Workiva/web-platform-pp
@Workiva/rich-app-platform-pp

@maxwellpeterson-wf
Relax Action handler return type
5b514f0 
Helps with strong mode compliance and async methods
@aviary2-wf
Copy link

Raven

Number of Findings: 0

@georgelesica-wf
Copy link
Contributor

+1

1 similar comment
@evanweible-wf
Copy link
Contributor

+1

@evanweible-wf
Copy link
Contributor

+10

  • CI Passes

@evanweible-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit tests created/updated
    • n/a
  • All unit tests pass

Merging into master.

@evanweible-wf evanweible-wf merged commit d58c29b into master Jan 26, 2017
@rmconsole3-wf rmconsole3-wf changed the title Relax Action handler return type CP-3349 Relax Action handler return type Jan 26, 2017
@rm-astro-wf rm-astro-wf mentioned this pull request Jan 26, 2017
Merged
@evanweible-wf evanweible-wf deleted the action-handler-return-type branch May 2, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxwellpeterson-wf @aviary2-wf @georgelesica-wf @evanweible-wf