Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-1192 Store: switch to a default ctor and a transformer ctor #49

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

evanweible-wf
Copy link
Contributor

Issue

Changes

Source:

Tests:

  • Update test for transformer usage.

Areas of Regression

  • Store streams (transformed or not).

Testing

  • CI passes.

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@codecov-io
Copy link

Current coverage is 100.00%

Merging #49 into master will not affect coverage as of 2f89a51

Powered by Codecov. Updated on successful CI builds.

@trentgrover-wf
Copy link
Contributor

+1

1 similar comment
@dustinlessard-wf
Copy link
Contributor

+1

@evanweible-wf
Copy link
Contributor Author

@trentgrover-wf @dustinlessard-wf sorry, forgot to update the readme. Should be good now.

@dustinlessard-wf
Copy link
Contributor

+1

1 similar comment
@trentgrover-wf
Copy link
Contributor

+1

@evanweible-wf
Copy link
Contributor Author

@jayudey-wf ready for merge.

@trentgrover-wf
Copy link
Contributor

@jayudey-wf let's merge and tag the other outstanding PR before this, since this will be a breaking change

@evanweible-wf
Copy link
Contributor Author

good call

@jayudey-wf jayudey-wf changed the title Store: switch to a default ctor and a transformer ctor CP-1192 Store: switch to a default ctor and a transformer ctor Dec 14, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI with updated unit test
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Dec 14, 2015
CP-1192 Store: switch to a default ctor and a transformer ctor
@jayudey-wf jayudey-wf merged commit 443442d into master Dec 14, 2015
@evanweible-wf evanweible-wf deleted the store-constructors branch May 2, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants