-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-1192 Store: switch to a default ctor and a transformer ctor #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
+1 |
1 similar comment
+1 |
evanweible-wf
force-pushed
the
store-constructors
branch
from
December 11, 2015 21:39
302dd81
to
2f89a51
Compare
@trentgrover-wf @dustinlessard-wf sorry, forgot to update the readme. Should be good now. |
+1 |
1 similar comment
+1 |
@jayudey-wf ready for merge. |
@jayudey-wf let's merge and tag the other outstanding PR before this, since this will be a breaking change |
good call |
jayudey-wf
changed the title
Store: switch to a default ctor and a transformer ctor
CP-1192 Store: switch to a default ctor and a transformer ctor
Dec 14, 2015
QA Resource Approval: +10
Merging into master. |
jayudey-wf
added a commit
that referenced
this pull request
Dec 14, 2015
CP-1192 Store: switch to a default ctor and a transformer ctor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Store
has optional parameters, extending classes cannot mix other classes in.Changes
Source:
transformer
parameter from the defaultStore
constructor and replacing it with a namedStore.withTransformer()
constructor. This is a breaking change.Tests:
Areas of Regression
Testing
Code Review
@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf