-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP-5043 Improve store state error messages #109
Conversation
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 5 5
Lines 62 62
=======================================
Hits 56 56
Misses 6 6
Continue to review full report at Codecov.
|
+10 |
@jayudey-wf you want to do the honors? |
QA +1
Merging into master |
+1 from RM |
Problem
The message associated with the
StateError
that is thrown when an action subscription is managed or when the store is listened to after disposal is cryptic.Solution
Add the
runtimeType
to help the situation a bit.Potential Regressions
None.
Tests
Existing tests are sufficient, the new error message is an ergonomic issue.
QA / +10
FYI
@seanburke-wf