-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEA-3239: Updated scip Protobuf #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
todbachman-wf
approved these changes
Jan 30, 2024
QA +1 indexed and uploaded scip-dart to sourcegraph, verified that uploaded analysis is as you would expect |
🚀 @Workiva/release-management-p 🚢 |
rmconsole-wf
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEA-3239
The protobuf spec for scip has changed a good amount since the scip-dart indexer was originally written, this pr bumps, and regenerates protobuf assets from
0.2.3
to0.3.3
The main major code difference being the introduction of
signatureDocumentation
, an alternative to just re-using thedocumentation
field onSymbolInformation
to provide the display string of the symbol in question. One nice this about this change, is the reduction in snapshot bloat that the snapshot tests have (Closes #87)One other addition is the concept of
PositionEncoding
, this should also be populated, but I'm currently unsure what value it should be for the dart language in particular. This will be set as a followup in #115QA
signatureDocumentation
, verifying that signatures are populated in the sourcegraph popover