-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-3143 Null Safety Codemod for connect props #302
Conversation
# Conflicts: # lib/src/executables/null_safety_migrator_companion.dart
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, QAing now
lib/src/dart3_suggestors/null_safety_prep/connect_required_props.dart
Outdated
Show resolved
Hide resolved
test/test_fixtures/required_props/test_package/lib/src/test_state.dart
Outdated
Show resolved
Hide resolved
lib/src/dart3_suggestors/null_safety_prep/connect_required_props.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
This is based on #298 to share the new e2e tests
Closes #295
Motivation
Currently, after migrating connected components, required prop validation throws when consuming those components for any required props that are only set within mapStateToProps/mapActionsToProps/etc.
https://workiva.slack.com/archives/CEFTMBPAA/p1726516120035799
Workiva/over_react#942 (comment)
There are quite a few usages of connect (SourceGraph) that will be impacted as they migrate to null safety, so we should codemod them
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: