FED-2444 Null safety preparation for conditional prop function calls

[aaronlademann-wf]

Motivation

Functions passed in as prop values are often null checked before being called using patterns that do not migrate nicely to null-safety - requiring the use of the ! assertion like so:

if (props.onClick != null) {
  props.onClick!(event);
}
// or
if (props.onClick != null) props.onClick!(event);

Changes

1. Add a suggestor that removes the separate conditional null check and instead adds a null-aware ? operator
2. Add the suggestor to the existing null_safety_prep executable.
3. Write tests.

What it does

Before

if (props.onClick != null) {
  props.onClick(event);
}
// or
if (props.onClick != null) props.onClick(event);

After

props.onClick?.call(event);

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[greglittlefield-wf]

Looking good, left some comments on cases to handle and tests

[aaronlademann-wf]

All feedback addressed!

[greglittlefield-wf]

Thanks for addressing that feedback! Just one more small comment, otherwise LGTM; I also tested it locally and it works great!

[greglittlefield-wf]

+10

[greglittlefield-wf]

+10

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM