UIP-2272 Remove test utilities that belong in over_react_test #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
tool/dev.dart
Outdated
| @@ -36,8 +36,7 @@ main(List<String> args) async { | |||
| // See https://github.com/Workiva/over_react/issues/36 | |||
| // 'chrome', | |||
| ] | |||
| // Prevent test load timeouts on Smithy. | |||
| ..concurrency = 1 | |||
| ..concurrency = 4 | |||
There was a problem hiding this comment.
#nit 4 is the default, this can just be removed
pubspec.yaml
Outdated
| dependency_overrides: | ||
| over_react_test: | ||
| git: | ||
| url: git@github.com:aaronlademann-wf/over_react_test.git |
There was a problem hiding this comment.
travis doesn't support SSH urls :(
There was a problem hiding this comment.
Yeah, this will have to get removed before we merge anyway 🤷♂️
|
@aaronlademann-wf This pull request has merge conflicts, please resolve. |
+ And move all remaining utils out of the “wsd_test_utils” directory + Consumers of this lib have no idea what wsd is / means.
+ We don’t have enough tests in this lib to need the syncronous workaround for test timeouts.
32476f5 to
e9e989f
Compare
+ 4 is the default.
|
@jacehensley-wf @greglittlefield-wf @clairesarsam-wf this no longer has a dependent PR, and is ready for a final pass. Now that over_react_test |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 94.87% 94.34% -0.52%
==========================================
Files 31 31
Lines 1537 1537
==========================================
- Hits 1458 1450 -8
- Misses 79 87 +8 |
|
@jacehensley-wf @greglittlefield-wf @clairesarsam-wf this is ready for review. |
|
+1 |
|
QA +10
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
There were some test utilities in this library that were not exposed / available for consumers.
How it was fixed:
Move them to over_react_test
Testing suggestions:
Passing CI
Areas of regression
Tests
FYA: @jacehensley-wf @greglittlefield-wf @clairesarsam-wf