Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-2960 Update the null safety migration documentation #932

Merged
merged 8 commits into from
Jul 17, 2024
Merged

FED-2960 Update the null safety migration documentation #932

merged 8 commits into from
Jul 17, 2024

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Jul 16, 2024 •
edited
Loading

The null safety migration documentation needs to be updated. This PR updates it with more helpful information for consumers.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review July 16, 2024 23:40
greglittlefield-wf
greglittlefield-wf requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments and a question, otherwise looks great!

doc/null_safety/null_safe_migration.md Show resolved Hide resolved
doc/null_safety/null_safe_migration.md Outdated Show resolved Hide resolved
doc/null_safety/null_safe_migration.md Show resolved Hide resolved
doc/null_safety/null_safe_migration.md Show resolved Hide resolved
greglittlefield-wf
greglittlefield-wf approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@greglittlefield-wf
Copy link
Contributor

@Workiva/release-management-p

@rmconsole2-wf rmconsole2-wf merged commit a855784 into master Jul 17, 2024
5 checks passed
rmconsole-wf
rmconsole-wf approved these changes Jul 17, 2024
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf deleted the FED-2960_ns-docs branch July 17, 2024 19:07
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@greglittlefield-wf greglittlefield-wf greglittlefield-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronlademann-wf @aviary3-wk @greglittlefield-wf @rmconsole-wf @rmconsole2-wf