FED-734 CI cleanup: remove failing stable config, add 2.18 config #805

greglittlefield-wf · 2023-02-07T23:58:42Z

Motivation

The GitHub Actions "build" job, which is our main set of CI checks, hasn't only been running on 2.13.4 for a long time, and nothing newer. I'd really like to include a build for 2.18
The "validate_analyzer" job is failing on Dart stable due to a Dart SDK bug that we're unable to work around at this time, so we want to disable it.

Changes

Add 2.18.7 to the build matrix, since it's the latest Dart SDK version we can build with
- Fix test failures in newer SDKs
- Ignore part_of_different_library errors
- Upgrade mockito since it older versions were causing build failures (merge in Upgrade to mockito v5 #789) - thanks @evanweible-wf!
- Fix usages of the dartanalyzer command removed in newer SDKs
- Fix VM test command to not use build_runner
- Update built_redux/mockito generated file checks to only run in 2.18.7
Remove validate_analyzer config, since it isn't needed once Raise analyzer minimum & unpin meta #804 constrains our analyzer dependency to a single major version
- We can reinstate this if we ever need to support multiple versions again in the future

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

Tests were updated and provide good coverage of the changeset and other affected code
Manual testing was performed if needed
- Steps from PR author:
  - CI passes
- Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

A Frontend Frameworks Design member has reviewed these changes
There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
For release PRs - Version metadata in Rosie comment is correct

… version

aviary-wf · 2023-02-07T23:59:59Z

Security Insights

No security relevant content was detected by automated scans.

Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

greglittlefield-wf · 2023-02-08T00:13:37Z

app/over_react_redux/todo_client/pubspec.yaml

@@ -7,7 +7,7 @@ environment:
 dependencies:
  color: any
  memoize: ^2.0.0
-  meta: ^1.6.0 # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142


These comments were outdated, so I cleaned them up

greglittlefield-wf · 2023-02-08T00:40:00Z

test/over_react/util/react_wrappers_test.dart

@@ -1063,19 +1063,25 @@ main() {
              expect(result2, same(result1), reason: 'should have returned the same object');
            }, tags: 'no-ddc');

-            test('unless the runtime is the DDC', () {


Basically, before we were testing that caching wasn't happening in DDC, which wasn't really the behavior we wanted ensure. I replaced it with a test that validates that it doesn't break, which is really the behavior we're after, at least for older SDKs.

…_to:cache files

Failures look like: Failed to load "test/over_react_component_declaration_test.dart": Timed out waiting for Chrome to connect

robbecker-wf

Looks good. Thanks for the detailed comments on why things were done.

robbecker-wf · 2023-02-08T17:52:22Z

QA+1 CI Passes on 2.13 and 2.18
tests updated and pass with newer mockito

greglittlefield-wf · 2023-02-08T17:55:17Z

@Workiva/release-management-p

rmconsole-wf

+1 from RM

evanweible-wf and others added 5 commits October 25, 2022 17:33

Upgrade to mockito v5

c80c972

Remove use of dartanalyzer, removed in newer SDKs

d6e5103

Fix tests in stable SDK

e319142

Add 2.18.7 to matrix

557b05f

Remove validate_analyzer since in #804 we only support a single major…

c434dea

… version

rmconsole-wf added the Merge Requirements Unmet label Feb 7, 2023

rmconsole-wf added the Skynet 2.0 Failed label Feb 8, 2023

greglittlefield-wf added 2 commits February 7, 2023 17:12

Merge remote-tracking branch 'origin/master' into ci-cleanup

eeab663

Clean up outdated comments

80cb1eb

greglittlefield-wf commented Feb 8, 2023

View reviewed changes

greglittlefield-wf added 5 commits February 7, 2023 17:18

Merge remote-tracking branch 'origin/mockito5' into ci-cleanup

10120cf

Raise mockito lower bound

160b45e

Update generated mockito file

05c135e

Update generated built_redux file, update build check

cd883e3

Also only check mockito generated files in a single SDK

d2558be

greglittlefield-wf commented Feb 8, 2023

View reviewed changes

greglittlefield-wf added 3 commits February 7, 2023 17:54

Fix VM test command

5b6fa03

Work around false positive part_of_different_library errors for build…

1311722

…_to:cache files

Work around test load timeout

0269012

Failures look like: Failed to load "test/over_react_component_declaration_test.dart": Timed out waiting for Chrome to connect

greglittlefield-wf marked this pull request as ready for review February 8, 2023 01:24

Update dependency_validator ignores

14b325e

greglittlefield-wf changed the title ~~CI cleanup: remove failing stable config, add 2.18 config~~ CI cleanup: remove failing stable config, add 2.18 config, upgrade mockito Feb 8, 2023

greglittlefield-wf requested review from robbecker-wf and evanweible-wf February 8, 2023 01:32

rmconsole6-wk changed the title ~~CI cleanup: remove failing stable config, add 2.18 config, upgrade mockito~~ FED-734 CI cleanup: remove failing stable config, add 2.18 config Feb 8, 2023

rmconsole-wf removed the Skynet 2.0 Failed label Feb 8, 2023

robbecker-wf approved these changes Feb 8, 2023

View reviewed changes

evanweible-wf approved these changes Feb 8, 2023

View reviewed changes

rmconsole-wf added Merge Requirements Met and removed Merge Requirements Unmet labels Feb 8, 2023

rmconsole-wf added the RM Ready label Feb 8, 2023

rmconsole-wf approved these changes Feb 8, 2023

View reviewed changes

rmconsole7-wk merged commit 05f11f2 into master Feb 8, 2023

rmconsole7-wk deleted the ci-cleanup branch February 8, 2023 17:55

rmconsole-readonly-wk mentioned this pull request Feb 8, 2023

RM-179069 RM-179068 Release over_react 4.8.2 #806

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FED-734 CI cleanup: remove failing stable config, add 2.18 config #805

FED-734 CI cleanup: remove failing stable config, add 2.18 config #805

greglittlefield-wf commented Feb 7, 2023 •

edited

Loading

aviary-wf commented Feb 7, 2023

greglittlefield-wf Feb 8, 2023

greglittlefield-wf Feb 8, 2023

robbecker-wf left a comment

robbecker-wf commented Feb 8, 2023

greglittlefield-wf commented Feb 8, 2023

rmconsole-wf left a comment

FED-734 CI cleanup: remove failing stable config, add 2.18 config #805

FED-734 CI cleanup: remove failing stable config, add 2.18 config #805

Conversation

greglittlefield-wf commented Feb 7, 2023 • edited Loading

Motivation

Changes

Release Notes

Review

QA Checklist

Merge Checklist

aviary-wf commented Feb 7, 2023

Security Insights

Action Items

greglittlefield-wf Feb 8, 2023

Choose a reason for hiding this comment

greglittlefield-wf Feb 8, 2023

Choose a reason for hiding this comment

robbecker-wf left a comment

Choose a reason for hiding this comment

robbecker-wf commented Feb 8, 2023

greglittlefield-wf commented Feb 8, 2023

rmconsole-wf left a comment

Choose a reason for hiding this comment

greglittlefield-wf commented Feb 7, 2023 •

edited

Loading