-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-471 Add utilities for jsifying/unsifying context props #785
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
AWESOME!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
- Tested in unified using the analogous RMUI branch, everything context related works as expected.
@Workiva/release-management-pp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Some JS components accept a custom React Context as a prop, and we want to support interop-ing with those components in a consumer-friendly way.
In react-dart/over_react, APIs that deal with React context, like
createContext
anduseContext
, use a Dart wrapper around the JS React context object.So, consumers are dealing with Dart context, while JS components need JS context. Ideally, consumers shouldn't have to manually wrap/unwrap context when they're passing it to/from JS components.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: