Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-16997 Fix selector hooks redrawing when values haven't changed #730

Merged
merged 20 commits into from
Feb 3, 2022
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
64d087e
Fix selectors always returning new objects by conditionally wrapping …
greglittlefield-wf Feb 2, 2022
c01d310
Reuse wrapped functions
greglittlefield-wf Feb 2, 2022
2c68978
Add regression tests
greglittlefield-wf Feb 2, 2022
5e12f20
Fix missing arg causing swallowed RTEs
greglittlefield-wf Feb 2, 2022
4dfb35d
Fix missing arg causing swallowed RTEs for createSelectorHook
greglittlefield-wf Feb 2, 2022
656cfca
Add some shared tests for different selected value types
greglittlefield-wf Feb 2, 2022
df95525
Add test coverage for createSelector, add null case and additional se…
greglittlefield-wf Feb 3, 2022
d472036
Use typed props
greglittlefield-wf Feb 3, 2022
498c594
Fix typo
greglittlefield-wf Feb 3, 2022
2e74a56
Update typing from dynamic to Object to prevent unintentional implici…
greglittlefield-wf Feb 3, 2022
4202bc5
Revert changes in old tests
greglittlefield-wf Feb 3, 2022
f4f3ae4
Remove unused dependency
greglittlefield-wf Feb 3, 2022
5973053
Add more test coverage
greglittlefield-wf Feb 3, 2022
2880847
Cleanup
greglittlefield-wf Feb 3, 2022
7cee6c0
Add test coverage for value identity
greglittlefield-wf Feb 3, 2022
abe3425
Add additional test coverage for connect
greglittlefield-wf Feb 3, 2022
e7cabbd
Add comment
greglittlefield-wf Feb 3, 2022
b199497
Add useSelector example
greglittlefield-wf Feb 3, 2022
b55e993
Update doc comment to not get flagged by dependency_validator
greglittlefield-wf Feb 3, 2022
cb65a0e
Fix copyright headers
greglittlefield-wf Feb 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some shared tests for different selected value types
  • Loading branch information
greglittlefield-wf committed Feb 2, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 656cfca43d5dabce8cd77ac5c6213666bb6e9fff
Loading