UIP-2304 Don't run ValidationUtil-related tests in dart2js #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 28 28
Lines 1380 1380
=======================================
Hits 1348 1348
Misses 32 32 |
|
+1 |
|
QA +10
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
A test was failing in dart2js due to validation warnings being compiled out.
How it was fixed:
Don't run those tests in js.
Testing suggestions:
pub run dart_dev test -p chromeand verify that all tests passPotential areas of regression:
Unit tests