-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen Dependency Ranges Blocking Dart 2.13 #695
Widen Dependency Ranges Blocking Dart 2.13 #695
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
7b16f95
to
c7ea908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI checks that are failing are also failing on master.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@Workiva/release-management-pp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
+ To prevent dependency gridlock downstream + The 1.1.6 lower bound is what was originally implemented for the Dart 2.13 migration effort (#695), and I accidentally bumped the lower bound to what it was before the 2.13 effort commit not realizing that it was intentionally being lowered.
Motivation
In order for projects to be compatible with Dart 2.13, there are dependencies that need to have their ranges widened.
For a list of dependencies expected to be changed, see the dependencies section of the Dart 2.12+ wiki page.
Another necessary change is the removal of
build_vm_compilers
. If this is the case, additional clean up may need to be done, such as removing the associated config frombuild.yaml
or updating how tests are run. A member of Client Platform will be following up with PRs that have CI failures to resolve any issues or perform necessary clean up.For any questions or concerns, don't hesitate to reach us in the #support-client-plat Slack channel!
Changes
build_vm_compilers
if it was presentQA
Created by Sourcegraph batch change
Workiva/dart_213_dependency_range_widen
.