-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy language version comments to generated part files #689
Conversation
(Based on @aaron.lademann@workiva.com's work)
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on wdesk and it indeed copied the language version correctly
bf14de0
to
2d1c27c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@Workiva/release-management-pp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Libraries with language version comments must have the same version comments in all of their part files.
As a result, it's currently impossible to add a language version comment to a file with a generated over_react part, since the generated part never includes a language version comment.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
pub run build_runner --build-filter='**.g.dart'
to build only Dart files and not JSMerge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: