Use propsOrStateMapsEqual in memo so that tearoffs don't cause unnecessary rerenders #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tearoffs aren't guaranteed to be identical, and we don't want the use of them to trigger unnecessary rerenders in
memo
ized function components.Closely related to how we handled this same problem for
connect
ed componentsChanges
propsOrStateMapsEqual
forareEqual
instead of default JS equality when the consumer does not specify their own custom handler for theareEqual
parameter.memo
.