Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-11503 CSS in JS #617

Closed
wants to merge 17 commits into from
Closed

Conversation

joebingham-wk
Copy link
Contributor

@joebingham-wk joebingham-wk commented Aug 13, 2020

This draft just shows the examples created in conjunction with the related react_material_ui changeset.

An example directory was added as a playground for material UI related changes. This playground is meant to be closely coupled with this JS project. Ideally, both can be run simultaneously and the DOM can be compared between the Dart example and the pure JS example to ensure behavior is the same.

None of these changes should be merged, this is just a place to view the consumption syntax and be able to run a working example :)

Motivation

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

git:
url: git@github.com:cleandart/react-dart.git
ref: 5.5.0/mui-experiments
path: ../../../../react-dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify for future peeps, this is 5.5.0/mui-experiments !

@joebingham-wk joebingham-wk changed the base branch from react_material to master August 14, 2020 20:20
@joebingham-wk joebingham-wk changed the base branch from master to react_material August 14, 2020 20:21
@joebingham-wk
Copy link
Contributor Author

Closed because I moved the example into the react_material_ui repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants