-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-3873 Function Components #606
Merged
greglittlefield-wf
merged 41 commits into
function-components-wip
from
CPLAT-3873-function-components
Jul 27, 2020
Merged
Changes from 12 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
dd8bb52
Initial spike for other branch
sydneyjodon-wk a81cdf8
Add v5_functionComponent to parsing versions
sydneyjodon-wk 8e2d970
Update generated file and error handling
sydneyjodon-wk d773544
Parse ComponentFactoryDeclarations
sydneyjodon-wk 86bc327
Remove v5 and update PropsMapViewOrFunctionComponentDeclaration
sydneyjodon-wk 6958e22
Update example
sydneyjodon-wk 7dc77f6
Add codegen for FunctionComponentConfig
sydneyjodon-wk 027cd66
Fix test failures and format
sydneyjodon-wk 3e62161
Update getPropsNameFromConfig
sydneyjodon-wk e2da213
Add initial parsing tests
sydneyjodon-wk 42005e2
Generate config for each factory to keep correct displayName
sydneyjodon-wk 685e9d7
Add parsing for generic function components
sydneyjodon-wk 659692e
Move defaultProps to react-dart
sydneyjodon-wk 1d614a9
Update pubspec dependency override
sydneyjodon-wk f57ea6c
Add codegen tests
sydneyjodon-wk 68db3d4
Handle parsing null config and custom props factory
sydneyjodon-wk d9d0708
Add function component snippets
sydneyjodon-wk d71da40
Format
sydneyjodon-wk 4885e6b
Merge branch 'master' into CPLAT-3873-function-components
sydneyjodon-wk b19542c
Initial integration tests
sydneyjodon-wk 49d1f5e
Merge branch 'master' into CPLAT-3873-function-components
sydneyjodon-wk 27bc400
Revert "Initial integration tests"
sydneyjodon-wk 3828257
Revert "Revert "Initial integration tests""
sydneyjodon-wk 6fa267e
Remove unused import
sydneyjodon-wk 0a4d434
Add tests based on component tests
sydneyjodon-wk 9ef8829
Add test cases for custom PropsFactory
sydneyjodon-wk a2d31b2
Add tests for function components using UiProps
sydneyjodon-wk e43751a
Remove defaultProps and update examples
sydneyjodon-wk f99e40d
Cleanup tests
sydneyjodon-wk 3a2daeb
Remove unused import
sydneyjodon-wk 59e8d8e
Update function name and doc comments
sydneyjodon-wk b759f8a
Update migration guide examples
sydneyjodon-wk cec79b9
Update based on reviewer feedback
sydneyjodon-wk f117e9d
Merge 'upstream/function-components-wip' into CPLAT-3873-function-com…
aaronlademann-wf d1c01d7
Remove yield for non-generated factories
sydneyjodon-wk eaa69ca
Add factory grouping and update examples
sydneyjodon-wk 0e38d4d
Add parsing for hocs and update wrapper function typing
sydneyjodon-wk 82f92a4
Run build and add null check
sydneyjodon-wk 0fd444a
Update generic args for uiFunction
sydneyjodon-wk e7a263d
Update uiFunction args
sydneyjodon-wk c22f0a2
Address feedback
sydneyjodon-wk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFD used both names for this function.
uiFunction
was what the ticket said to name it, but if anyone thinks it should beuiFunctionComponent
I can update it.