Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-12081 Readme Improvements #487

Merged
merged 17 commits into from
Sep 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,10 @@ __Analyzer Plugin Changes:__
the awesome [redux.dart library](https://github.com/johnpryan/redux.dart) to make it easy
to set up redux provider(s) / consumer(s) for OverReact components that enable granular, targeted updates!
- Check out [some examples](https://github.com/Workiva/over_react/tree/master/web/over_react_redux)
by cloning this project locally, running `webdev serve` from the root of the project, and navigating to <http://localhost:8080/over_react_redux/>.
by cloning this project locally, running `webdev serve` from the root of the project, and navigating to `http://localhost:8080/over_react_redux/`.
- Use it in your project by [upgrading your `UiComponent`s to `UiComponent2`](https://github.com/Workiva/over_react/blob/master/doc/ui_component2_transition.md#updating) and importing `package:over_react/over_react_redux.dart`!
- We've even got some sweet [redux dev tools you can use](https://github.com/Workiva/over_react/blob/master/doc/over_react_redux_documentation.md#using-redux-devtools) to make the inspection of connected state a breeze!
![over_react_redux.dart developer tools](http://g.recordit.co/NLeAZQkCFm.gif)
![over_react_redux.dart developer tools](https://g.recordit.co/NLeAZQkCFm.gif)

> [__Learn more about using over_react_redux.dart__](https://github.com/Workiva/over_react/blob/master/doc/over_react_redux_documentation.md)

Expand Down Expand Up @@ -1014,7 +1014,7 @@ __Bug Fixes__

__New Features__

* [#76]: Add support for [`covariant`](http://news.dartlang.org/2017/02/dart-122-faster-tools-assert-messages.html) props / state fields.
* [#76]: Add support for [`covariant`](https://news.dartlang.org/2017/02/dart-122-faster-tools-assert-messages.html) props / state fields.
* Closes [#49]

__Bug Fixes__
Expand Down
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ thank you!)
detail as necessary.
1. See instructions in PR template for getting review on your changes.

## Running Unit Tests Locally
When running tests in `over_react`, our `dart_test.yaml` specifies some handy presets for running tests in DDC and dart2js:

* To run tests in `over_react` compiled via __DDC__, run:
```bash
$ pub run build_runner test -- -P dartdevc
```

* To run tests in `over_react` compiled via __dart2js__, run:
```bash
$ pub run build_runner test -r -- -P dart2js
```

### Coding Standards
A lot can be gained by writing code in a consistent way. Moreover, always
Expand Down
Loading