CPLAT-8834 fix tests for redux 7.1.3 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
approved these changes
Dec 11, 2019
| // then `areStatesEqual` shows up 2 times due to `initialState`. | ||
| expect(methodsCalled, ['mapStateToProps', 'areStatesEqual', 'areStatesEqual']); | ||
| expect(methodsCalled, contains('mapStateToProps')); | ||
| expect(methodsCalled, contains('areStatesEqual')); |
There was a problem hiding this comment.
FYI you can also do
containsAll(['mapStateToProps', 'areStatesEqual']));
aaronlademann-wf
added a commit
to Workiva/react-dart
that referenced
this pull request
Dec 12, 2019
+ Once we get all consumers sorted out with their tests that were assuming that the js `Provider` exposed by react-redux (e.g. Workiva/over_react#440), we can safely release this.
aaronlademann-wf
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
+10
- All tests passed locally when pointing to Workiva/react-dart@fb5fdab - which contains the version of react-redux that broke all the things before.
@Workiva/release-management-pp
keepsimple7
added a commit
to keepsimple7/react-dart-expander
that referenced
this pull request
Aug 15, 2022
+ Once we get all consumers sorted out with their tests that were assuming that the js `Provider` exposed by react-redux (e.g. Workiva/over_react#440), we can safely release this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The NPM package
react-reduxthat over_react consumes from react-dart changed its "Provider" component from a class based component to a function component in the 7.1.1 patch version. This broke some expectations that our tests had in place for over_react_redux.Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
packages.json'sreact-reduxversion to"7.1.3"npm run buildand publink react-dart to over_react.pub run dart_dev test -P dartdevcand make sure all tests pass.pub run dart_dev test --build-args="-r" -P dart2jsand make sure all tests pass.Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: