Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-8603 Add Multiple Error Check to ErrorBoundary #432

Merged
merged 6 commits into from
Nov 27, 2019

Conversation

joebingham-wk
Copy link
Contributor

@joebingham-wk joebingham-wk commented Nov 25, 2019

Motivation

Currently, an ErrorBoundary can be fooled to think that the UI is recoverable by a call stack varying even though the same two or three call stack repeatedly occurs.

Changes

  • Keep track of all errors thrown in the same 5 second interval.

Release Notes

  • Add ErrorBoundary fix that helps to prevent recovery attempts after the UI is unrecoverable.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@kealjones-wk @greglittlefield-wf @sydneyjodon-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
    • Test in wdesk_sdk to ensure an infinite loop can no longer occur
      • Add a virtualized list as the content to a side panel element (I was using header_footer_properties_panel_content.dart). You can override that file with this gist that has a virtual list.
      • Override web_skin_dart and add an error that gets thrown on mount in RegionComponent
      • Override over_react with this branch
      • Run the wdesk_sdk app, clicking into a document, the side panel, and the second tab within the panel navigation. For the purposes of this test, the document should unmount and not enter an infinite loop. Removing the over_react override and doing the same test should result in an infinite loop
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@joebingham-wk joebingham-wk marked this pull request as ready for review November 25, 2019 21:44
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Nice job on this implementation and tests!!

@rmconsole2-wf rmconsole2-wf changed the title Add Multiple Error Check to ErrorBoundary CPLAT-8603 Add Multiple Error Check to ErrorBoundary Nov 26, 2019
@greglittlefield-wf
Copy link
Contributor

+10

@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants