Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-6244: DO NOT MERGE: Upgrade to analyzer 0.36.x and build_web_compilers 2.x #310

Merged
merged 4 commits into from
Jun 27, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Jun 20, 2019

CPLAT-6244

Issue Status

Motivation

We want to make sure over_react works with the latest analyzer and we want to upgrade to the latest build packages.

Changes

  • Widen analyzer range to include 0.36.x
  • Upgrade to build_web_compilers 2.x
  • Remove the coverage dep and the generate_coverage.sh script as they currently don't work on dart2

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf evanweible-wf changed the title DO NOT MERGE: Upgrade to analyzer 0.36.x and build_web_compilers 2.x Upgrade to analyzer 0.36.x and build_web_compilers 2.x Jun 27, 2019
@rmconsole7-wk rmconsole7-wk changed the title Upgrade to analyzer 0.36.x and build_web_compilers 2.x CPLAT-6244 DO NOT MERGE: Upgrade to analyzer 0.36.x and build_web_compilers 2.x Jun 27, 2019
@charliekump-wf charliekump-wf changed the title CPLAT-6244 DO NOT MERGE: Upgrade to analyzer 0.36.x and build_web_compilers 2.x CPLAT-6244: DO NOT MERGE: Upgrade to analyzer 0.36.x and build_web_compilers 2.x Jun 27, 2019
@corwinsheahan-wf
Copy link
Contributor

QA +1

  • CI Passes

Merging into master.
@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants