-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-6138: Update handler chain utils for dart 2.4 compat #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanweible-wf
changed the title
Update handler chain utils for dart 2.4. compat
Update handler chain utils for dart 2.4 compat
Jun 18, 2019
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
rmconsole6-wk
changed the title
Update handler chain utils for dart 2.4 compat
CPLAT-6138 Update handler chain utils for dart 2.4 compat
Jun 18, 2019
charliekump-wf
changed the title
CPLAT-6138 Update handler chain utils for dart 2.4 compat
CPLAT-6138: Update handler chain utils for dart 2.4 compat
Jun 18, 2019
+1 to @evanweible-wf's commits |
aaronlademann-wf
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
QA +1
|
+1 to @greglittlefield-wf's commits |
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #304
CPLAT-6138
Motivation
When Dart 2.4 is released (imminent), it comes with a small breaking language change that unfortunately affects the handler chaining utils in this package. @greglittlefield-wf and @georgelesica-wf were able to update them in such a way that works around the breaking change without adversely affecting existing usages.
Changes
CallbackUtil
class no longer uses its generic type param (that previously was expected to extendFunction
) and instead explicitly marks the relevant types in the class body ascovariant Function
to achieve the same typing.CallbackUtilNArg
classes no longer specify a type param when extendingCallbackUtil
since it is unused.Fixes #304
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@greglittlefield-wf @georgelesica-wf @aaronlademann-wf
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: